Tidy up spectator clock/manager naming and interfaces #19933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Too many levels of redirection. One interface with one implementation is not useful, IMO.
Too many levels of redirection. One interface with one implementation is not useful, IMO.
smoogipoo
requested changes
Aug 24, 2022
osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/SpectatorSyncManager.cs
Outdated
Show resolved
Hide resolved
osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/SpectatorSyncManager.cs
Outdated
Show resolved
Hide resolved
smoogipoo
approved these changes
Aug 24, 2022
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pass with (hopefully) not functionality changes, aimed to make it easier to navigate around these classes.
Having interfaces for cases where there is only one implementation (into the foreseeable future) just adds to complexity with no perceived benefit.