-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add momentary shortcuts to toggle grid/distance snap #20828
Conversation
Matching osu!stable. I use these quite a lot while mapping and I'm sure others do as well. Hold `Shift` = invert grid snap Hold `Alt` = invert distance snap
I've fixed all the known edge cases I could find. Note that to make this work well, I limited the momentary toggles so only one can be utilised at once. If not for this, a case like the following could occur, requiring a stack of application history (and even then, it could go wrong if the mouse is used to toggle via a button):
I want to get this as close as possible without getting too complex, and I think what is on this branch should work for now. |
Found one more edge case that wasn't mentioned anywhere above, osu!-specific:
2022-10-21.22-51-49.mp4Works the other way round too, obviously. Unsure if you're aware of this, so holding off from doing anything further with this pull yet. I'm not hugely fussed, but it feels a little bad that this happens and I don't think it's not fixable with a reasonable amount of effort. |
I guess that's the same case I pointed out but reproduced much simpler. It's unfortunate and I'd like to fix it... but as you say it's going to take considerable thought. |
Should work better now (with the dependent PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, one slight problem, however...
Matching osu!stable. I use these quite a lot while mapping and I'm sure others do as well.
Hold
Shift
= invert grid snapHold
Alt
= invert distance snap