Update framework #20852
Merged
Update framework #20852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
previously approved these changes
Oct 21, 2022
frenzibyte
dismissed
their stale review
hold off, pending confirmation in ppy/osu-framework#5473
|
Latest framework release is somewhat broken (ppy/osu-framework#5473). May be best to not merge this, pull the release, merge that and then try again. |
frenzibyte
previously approved these changes
Oct 22, 2022
|
Tested resolution switching on windows to work correctly, so this should be good to go in theory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.