Add setting to allow forcing the game to draw over notches / cameras #20983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
safe-area-toggle
branch
from
6d2e47f
to
f9d2c30
Compare
bdach
approved these changes
Oct 29, 2022
frenzibyte
reviewed
Oct 29, 2022
Comment on lines
+247
to
+250
| if (host.Window?.SafeAreaPadding.Value.Total != Vector2.Zero) | ||
| safeAreaConsiderationsCheckbox.Show(); | ||
| else | ||
| safeAreaConsiderationsCheckbox.Hide(); |
There was a problem hiding this comment.
Slightly safer to update visibility based on value changes to host.Window.SafeAreaPadding in case it gets updated later than the display.
Comment on lines
+106
to
+110
| safeAreaConsiderationsCheckbox = new SettingsCheckbox | ||
| { | ||
| LabelText = "Shrink game to avoid cameras and notches", | ||
| Current = osuConfig.GetBindable<bool>(OsuSetting.SafeAreaConsiderations), | ||
| }, |
There was a problem hiding this comment.
The position of the checkbox feels weird, it's placed above more general options like "UI scaling" and "Screen scaling":
Think it would be better having it at the bottom instead?
There was a problem hiding this comment.
Disagree. This only shows on mobile. It makes sense for it to be the topmost setting there for me.
There was a problem hiding this comment.
Perhaps the padding is what makes it look weird. Dunno.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting will only show up when running on a device that exposes safe areas.
Addresses a common point of user contention as seen by the following discussions (and probably more):
#20970
#15506
#19737
#17769
#18395