Add recent section to user profile #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing JSON fields to response model - Add missing enum value
- Add a show user action to link handling
naoey
commented
Feb 26, 2018
| } | ||
| } | ||
|
|
||
| private string urlToAbsolute(string url) => $"{api?.Endpoint ?? @"https://osu.ppy.sh"}{url}"; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
- Also remove unnecessary fallback from absolute URL helper
- Also handle opening UserProfile in LinkFlowContainer similar to how beatmaps and channels are handled
naoey
force-pushed
the
user-profile-recent
branch
from
e1fffb6
to
2e535af
Compare
peppy
reviewed
Mar 3, 2018
| { | ||
| this.api = api; | ||
|
|
||
| userLinkTemplate = $"[{toAbsoluteUrl(activity.User?.Url)} {activity.User?.Username}]"; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
reviewed
Mar 5, 2018
|
|
||
| private MessageFormatter.MessageFormatterResult createMessage() | ||
| { | ||
| string userLinkTemplate = $"[{toAbsoluteUrl(activity.User?.Url)} {activity.User?.Username}]"; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
naoey
force-pushed
the
user-profile-recent
branch
from
18795b6
to
9669c5a
Compare
|
Looking good, apart from missing |
naoey
force-pushed
the
user-profile-recent
branch
from
7a2d53f
to
983cefb
Compare
peppy
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: