Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mania star difficulty calculation #2124

Merged
merged 8 commits into from Mar 12, 2018
Merged

Implement mania star difficulty calculation #2124

merged 8 commits into from Mar 12, 2018

Conversation

Poyo-SSB
Copy link
Contributor

Ported from stable with code-quality and context tweaks.

The "Hit window 300" difficulty category, like with Taiko, has yet to be implemented.

@peppy peppy added this to the Candidate Issues milestone Feb 28, 2018
@peppy peppy added pending review area:beatmap-parsing .osu file format parsing labels Feb 28, 2018
@peppy
Copy link
Sponsor Member

peppy commented Mar 3, 2018

Wanna take the last step and fix the remaining four CI issues? Then we can begin the review process.

smoogipoo
smoogipoo previously approved these changes Mar 12, 2018
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smoogipoo smoogipoo merged commit d88fb76 into ppy:master Mar 12, 2018
@Poyo-SSB Poyo-SSB deleted the mania-difficulty branch April 10, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:beatmap-parsing .osu file format parsing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants