Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split performance calculators #21938

Closed
wants to merge 3 commits into from
Closed

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Dec 29, 2022

This is a first step in making a proper lazer diff/pp calc. I'm not sure about the further direction I should take with the splitting yet, so I'm starting with just the safe refactor that doesn't require any infra-level changes

@peppy peppy added the blocked Don't merge this. label Dec 29, 2022
@peppy
Copy link
Sponsor Member

peppy commented Dec 29, 2022

Blocking ahead of time pending discussion on a public forum at some later date.

@stanriders
Copy link
Member Author

stanriders commented Dec 29, 2022

Blocking ahead of time pending discussion on a public forum at some later date.

I wanna clarify that this isn't something related to controversial things like rates and DA (at least with the current way diff/pp calc works). This is mostly just things that are a must for new score data
A hotfix pretty much, see this conversation

e: I've removed DA changes for now

@stanriders stanriders requested a review from a team December 29, 2022 23:07
@stanriders stanriders changed the title Split performance calculators, add DA to difficulty calculation Split performance calculators Dec 29, 2022
@peppy
Copy link
Sponsor Member

peppy commented Sep 4, 2023

It was brought up that this is a potential requirement for getting initial leaderboards online. @stanriders could you better describe what this is? Is the new class just a copy paste of the old one? Has it come from somewhere else?

Is there a reason we can't if certain parts of the main calculator rather than splitting into two? They should not differ that much. Maintaining two version is likely more complex than having one with pathing where required.

@stanriders
Copy link
Member Author

It was decided that split won't be required any time soon so I'm closing this PR

@stanriders stanriders closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants