New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mania hidden/fadein combo scaling coverage #22591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review. Only focusing on structure for now, haven't even looked as to whether any of the coverage numbers and formulae are anywhere close to correct.
This should now match stable when lazer another concern, the rate at which the civerage changes scales with the coverage setting. I feel like this makes the most sense, but I'd like a second opinion on if that is a valid direction. an alternative would be to scale linearly with combo (I.E. +1 combo is always +X% of the playfield, regardless of any setting) I have also entirely ingored designing how mod score multipliers should work with this since it was out of scope. However, there was the recent meeting discussing gameplay balance, so I am unsure if I now need to also include some plan for that. |
You could have two settings for initial and maximum coverage, similarly like the time ramp mods have an initial and final playback rate.
I think this makes sense also (and can tie nicely into the proposal above).
It is out of scope still. We probably need a holistic balance pass anyhow. |
Adds dynamic coverage for mania hidden/fadein mod which increases with combo. Enabled by default.
Default hidden coverage has been reduced so that default settings are closer to osu!stable gameplay.
Specific tuning of coverage and
combo_to_reach_max_coverage
will need mania community feedback since mania and hidden are things I am not great at.