Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DummyRuleset getting selected after non-matching filter #2262

Merged
merged 2 commits into from Mar 22, 2018
Merged

Fix DummyRuleset getting selected after non-matching filter #2262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6222930
Fix DummyRuleset getting selected
peppy Mar 21, 2018
13a3c72
Merge branch 'master' into fix-dummy-ruleset
smoogipoo Mar 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions osu.Game/Screens/Select/SongSelect.cs
View file
Open in desktop
Expand Up @@ -259,6 +259,8 @@ public void FinaliseSelection(BeatmapInfo beatmap = null)

private void workingBeatmapChanged(WorkingBeatmap beatmap)
{
if (beatmap is DummyWorkingBeatmap) return;

if (IsCurrentScreen && !Carousel.SelectBeatmap(beatmap?.BeatmapInfo, false))
// If selecting new beatmap without bypassing filters failed, there's possibly a ruleset mismatch
if (beatmap?.BeatmapInfo?.Ruleset != null && beatmap.BeatmapInfo.Ruleset != Ruleset.Value)
Expand Down