New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor structure and naming of skin-related classes #22648
Conversation
Also use full `SkinComponentsContainerLookup` instead of the sub-type. This will potentially be useful once we bring in per-ruleset targets.
And document the class better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Difficult diff to get through but that was to be expected. Generally feel that this is a net gain in legibility. Left some minor comments, nothing too major - whether they're actionable is mostly up to you.
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
I think I'm more or less fine with this now, save for the one remaining review thread - but just so I know for the near future (and can maybe expedite this a bit faster without having to go through the usual call-and-response), does this review request mean that you want an approval from @frenzibyte specifically here before merging? |
I was hoping for one, but I don't think it should hold things up so feel free to bypass it. This is going to be a dependency for all my forward work, so I'd prefer it merged ASAP so I can continue moving forward unencumbered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads pretty well to me. Nice one 👍🏻. @bdach requesting a final review from you since you've reviewed this before.
This is a full pass on the skin namespace, focused on renaming, documenting and generally knocking some (final?) sense into the structure and understandability before I attempt to make things more complicated.
SkinnableTargetComponentsContainer
#22647 (conflict avoidance)Note that I've intentionally avoided changing any naming or namespaces which would break existing usages / serialisation.