New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move binding to LoadComplete #2300

Merged
merged 2 commits into from Mar 24, 2018

Conversation

2 participants
@peppy
Member

peppy commented Mar 23, 2018

Previously there was a chance that it would still never get disposed, as the event was bound in async load, before it was in a state it can be recursively disposed via the PlayerLoader call.

Move binding to LoadComplete
Previously there was a chance that it would still never get disposed, as the event was bound in async load, before it was in a state it can be recursively disposed via the PlayerLoader call.

@peppy peppy added this to the March 2018 milestone Mar 23, 2018

@smoogipoo smoogipoo merged commit 01a6d77 into ppy:master Mar 24, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-skin-event-again branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment