/osu

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VisualTests/nUnit work again #2321

Merged
merged 14 commits into from Mar 29, 2018
+768 −161

Conversation

Reviewers

@smoogipoo smoogipoo

Assignees
No one assigned
Labels
Milestone
  .NET Standard
2 participants
@peppy @smoogipoo
@peppy
Member

peppy commented Mar 28, 2018 •
edited by smoogipoo

Closes #2318 (as alternative).
@peppy

This comment has been minimized.

Sign in to view
Member

peppy commented Mar 28, 2018 •
edited

Dropping this here as a current issue (vs2017 nuget restore fails, command line works fine): NuGet/Home#4706

@peppy peppy added this to the .NET Standard milestone Mar 28, 2018

@peppy peppy added code quality testing labels Mar 28, 2018

osu.Desktop/osu.Desktop.csproj Outdated
<AssemblyName>osu!</AssemblyName>
<Title>osu!lazer</Title>
<Product>osu!lazer</Product>
<ApplicationIcon>lazer.ico</ApplicationIcon>
<Configurations>$(CONFIGURATIONS);VisualTests</Configurations>
<Version>0.0.0.0</Version>
<FileVersion>0.0.0.0</FileVersion>

This comment has been minimized.

Sign in to view
Copy link
@smoogipoo

smoogipoo Mar 29, 2018

Contributor

I don't think you want to remove these two versions - they're used during deploy.

@smoogipoo smoogipoo merged commit fcf0b25 into ppy:master Mar 29, 2018
1 check passed

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-visual-tests branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment