Skip to content

/ osu

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VisualTests/nUnit work again #2321

Merged
merged 14 commits into from Mar 29, 2018
Merged

Make VisualTests/nUnit work again #2321

merged 14 commits into from Mar 29, 2018

Conversation

@peppy
Copy link
Member

@peppy peppy commented Mar 28, 2018 •
edited by smoogipoo

Closes #2318 (as alternative).
peppy added 8 commits Mar 28, 2018
@peppy
Make VisualTests/nUnit work again
Loading status checks…
94b1d3e
@peppy
Add back resources
Loading status checks…
4907f14
@peppy
Let appveyor do its own discovery
Loading status checks…
c355a07
@peppy
Consolidate and move ruleset test projects
0026b94
@peppy
Update vscode build configurations
Loading status checks…
093bd7d
@peppy
Add missing licence headers
Loading status checks…
9667d54
@peppy
Remove lingering reference to tests
81a8385
@peppy
Tidy up csproj further
Loading status checks…
9aae568
@peppy
Copy link
Member Author

@peppy peppy commented Mar 28, 2018 •
edited

Dropping this here as a current issue (vs2017 nuget restore fails, command line works fine): NuGet/Home#4706
peppy added 3 commits Mar 28, 2018
@peppy
Update test projects to actually load in visual studio
59df02d
@peppy
Remove VisualTests solution configuration
Loading status checks…
e47276c
@peppy
Update framework
Loading status checks…
01116a7
@peppy peppy added this to the .NET Standard milestone Mar 28, 2018
@smoogipoo
Add .vscode configurations for ruleset test projects
Loading status checks…
d83e4df
@smoogipoo
smoogipoo requested changes Mar 29, 2018
View changes
osu.Desktop/osu.Desktop.csproj Outdated
<AssemblyName>osu!</AssemblyName>
<Title>osu!lazer</Title>
<Product>osu!lazer</Product>
<ApplicationIcon>lazer.ico</ApplicationIcon>
<Configurations>$(CONFIGURATIONS);VisualTests</Configurations>
<Version>0.0.0.0</Version>
<FileVersion>0.0.0.0</FileVersion>

This comment has been minimized.

Sign in to view
@smoogipoo

smoogipoo Mar 29, 2018
Contributor

I don't think you want to remove these two versions - they're used during deploy.
smoogipoo added 2 commits Mar 29, 2018
@smoogipoo
Add back osu.Desktop versions (used in deploy)
687c889
@smoogipoo
Update framework
Loading status checks…
cc35b1a
@smoogipoo
smoogipoo approved these changes Mar 29, 2018
View changes
@smoogipoo smoogipoo merged commit fcf0b25 into ppy:master Mar 29, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy deleted the peppy:fix-visual-tests branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo

Assignees
No one assigned
Labels
type:code-quality type:testing
Projects
None yet
Milestone
.NET Standard
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@peppy @smoogipoo
You can’t perform that action at this time.