Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HardRock position mangling for CatchTheBeat #2366

Merged
merged 4 commits into from Apr 18, 2018
Merged

Conversation

@tgi74
Copy link
Contributor

@tgi74 tgi74 commented Apr 8, 2018

This code is from stable (see #1582).
Changed a bit to match lazer's ctb implementation.

Closes #1582

{
bool right = RNG.NextBool();

float rand = Math.Min(20, (float)RNG.NextDouble(0, timeDiff / 4));

This comment has been minimized.

@smoogipoo

smoogipoo Apr 9, 2018
Contributor

Can we keep the positions relative to [0, 1] and only divide by CatchPlayfield.BASE_SIZE here?


public void ApplyToHitObject(CatchHitObject hitObject)
{
// Code from Stable, we keep calculation on a scale of 0 to 512

This comment has been minimized.

@smoogipoo

smoogipoo Apr 9, 2018
Contributor

Would remove this comment, doesn't provide useful information.

@smoogipoo smoogipoo requested a review from peppy Apr 9, 2018
@smoogipoo smoogipoo dismissed their stale review Apr 9, 2018

fixed

@peppy
peppy approved these changes Apr 18, 2018
@peppy peppy merged commit 69a91c6 into ppy:master Apr 18, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants