Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up results screen statistic item flow #23718

Merged
merged 4 commits into from
Jun 4, 2023

Commits on Jun 1, 2023

  1. Configuration menu
    Copy the full SHA
    dc595b8 View commit details
    Browse the repository at this point in the history
  2. Return StatisticItems rather than StatisticRows from ruleset

    There were no usages of more than one column being provided per row, so
    it seemed like unnecessarily complexity. I'm currently trying to reduce
    complexity so we can improve the layout of the results screen, which
    currently has up to three levels of nested `GridContainer`s.
    
    Of note, I can't add backwards compatibility because the method
    signature has not changed in `Ruleset` (only the return type). If we do
    want to keep compatibility with other rulesets, we could designate a new
    name for the updated method.
    peppy committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    985604f View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Simplify column dimensions code

    `dimensions` would always receive exactly one item, so might as well
    inline it.
    
    And yes, at this point the grid container is mostly a glorified
    `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
    touching that in this pull pending further decisions with respect to
    direction.
    bdach committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    602d5db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    331e90f View commit details
    Browse the repository at this point in the history