Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNormalize line endings to LF #2378
Conversation
peppy
added this to the Candidate Issues milestone
Apr 11, 2018
peppy
added
the
code quality
label
Apr 11, 2018
peppy
added some commits
Apr 11, 2018
smoogipoo
merged commit 632befb
into
ppy:master
Apr 13, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
peppy
deleted the
peppy:fix-line-endings
branch
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
peppy commentedApr 11, 2018
•
edited
We probably want to do this. Unfortunately it's going to rewrite a lot of files, but kind of unavoidable.
autocrlfcorrectly.Should have no effect on existing PRs (have already tested a merge).
References: https://help.github.com/articles/dealing-with-line-endings/ and boogie-org/boogie#15