Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize line endings to LF #2378

Merged
merged 2 commits into from Apr 13, 2018
Merged

Normalize line endings to LF #2378

merged 2 commits into from Apr 13, 2018

Conversation

@peppy
Copy link
Member

@peppy peppy commented Apr 11, 2018

We probably want to do this. Unfortunately it's going to rewrite a lot of files, but kind of unavoidable.

  • Switches to applying line endings on checkout.
  • Uses CRLF for c# files for now, although this if likely not needed if users set autocrlf correctly.

Should have no effect on existing PRs (have already tested a merge).

References: https://help.github.com/articles/dealing-with-line-endings/ and boogie-org/boogie#15

@peppy peppy added this to the Candidate Issues milestone Apr 11, 2018
@peppy peppy force-pushed the peppy:fix-line-endings branch from ca832b2 to a29d64a Apr 13, 2018
@peppy peppy force-pushed the peppy:fix-line-endings branch from a29d64a to c6127dc Apr 13, 2018
@peppy peppy force-pushed the peppy:fix-line-endings branch from c6127dc to 32a74f9 Apr 13, 2018
@smoogipoo smoogipoo merged commit 632befb into ppy:master Apr 13, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy deleted the peppy:fix-line-endings branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.