Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Probably wouldn't recommend merging into any hotfix releases if anything of the sort is coming soon.
This precedes a fix to a bug in the metadata lookup flow I found a while back, loosely described in footnote 1 here. There are two reasons why I went off on this detour:
BeatmapUpdaterMetadataLookup
has the logic of applying the metadata of the map duplicated in two places (depending on whether API or the local metadata snapshot is being used), and I would have had to fix up both places as both are susceptible to the same bug that I want to fix. I find that kinda weird as the two places are doing precisely the same thing, based on the same type of data, which is just sourced from a different place. So this restructure kind of logically made sense to me.All of the above is mostly argumentative and subjective, and none of it is strictly necessary for fixing the bug that I want to fix, but I kind of like the end result. So I want to see what the reaction to this will be.