Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAuth token not saving often enough #2387

Merged
merged 2 commits into from Apr 12, 2018
Merged

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Apr 12, 2018

When forcefully closing osu! (debugger-stop/Cmd+Q), the token wouldn't get saved.

@peppy
peppy approved these changes Apr 12, 2018
@peppy peppy added the type:online label Apr 12, 2018
@peppy peppy added this to the April 2018 milestone Apr 12, 2018
@peppy
Copy link
Member

@peppy peppy commented Apr 12, 2018

Doesn't save on signing out any more, even on quite.

Please just basic tests before PRing.

Copy link
Member

@peppy peppy left a comment

broke

@peppy
Copy link
Member

@peppy peppy commented Apr 12, 2018

This isn't going to pick up on token refreshes, which don't trigger a state change.

@smoogipoo smoogipoo force-pushed the smoogipoo:oauth-token-logging branch from e8849d3 to 2c80133 Apr 12, 2018
@smoogipoo smoogipoo force-pushed the smoogipoo:oauth-token-logging branch from 2c80133 to baae442 Apr 12, 2018
@peppy peppy changed the title Save OAuth token with every successful login Fix OAuth token not saving often enough Apr 12, 2018
@peppy
peppy approved these changes Apr 12, 2018
@peppy peppy merged commit 47a78ff into ppy:master Apr 12, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:oauth-token-logging branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants