Fix OAuth token not saving often enough #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
approved these changes
Apr 12, 2018
|
Doesn't save on signing out any more, even on quite. Please just basic tests before PRing. |
|
This isn't going to pick up on token refreshes, which don't trigger a state change. |
smoogipoo
force-pushed
the
oauth-token-logging
branch
from
e8849d3
to
2c80133
Compare
smoogipoo
force-pushed
the
oauth-token-logging
branch
from
2c80133
to
baae442
Compare
peppy
changed the title
peppy
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When forcefully closing osu! (debugger-stop/Cmd+Q), the token wouldn't get saved.