Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAuth token not saving often enough #2387

Merged
merged 2 commits into from Apr 12, 2018

Conversation

smoogipoo
Copy link
Contributor

When forcefully closing osu! (debugger-stop/Cmd+Q), the token wouldn't get saved.

@peppy peppy added this to the April 2018 milestone Apr 12, 2018
@peppy
Copy link
Sponsor Member

peppy commented Apr 12, 2018

Doesn't save on signing out any more, even on quite.

Please just basic tests before PRing.

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broke

@peppy
Copy link
Sponsor Member

peppy commented Apr 12, 2018

This isn't going to pick up on token refreshes, which don't trigger a state change.

@peppy peppy changed the title Save OAuth token with every successful login Fix OAuth token not saving often enough Apr 12, 2018
@peppy peppy merged commit 47a78ff into ppy:master Apr 12, 2018
@smoogipoo smoogipoo deleted the oauth-token-logging branch June 15, 2018 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants