Disable hold end conversion for mania HoldOff mod #24552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is fine as is. As for score preservation, I wouldn't worry about it. Replays will play back fine. Online leaderboards will be wiped. The only hangup may be that total scores for local plays will no longer be correct but it's not something we can correct very easily anyways and I think the work required to do that far outweighs the scale of the problem. |
bdach
approved these changes
Aug 15, 2023
|
I think this is okay, and seems to translate quite well for most non-convert beatmaps. For some converts there's some long empty sections but probably fine to turn a blind eye. Example: disco prince, long slider: osu.2023-08-16.at.04.23.36.mp4 |
peppy
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24551
Beatmap: https://osu.ppy.sh/beatmapsets/1252675#mania/2603455
Before:
2023-08-15.19-28-09.mp4
After:
2023-08-15.19-29-16.mp4