Update spectator server development endpoint URLs #24718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the way `dev.ppy.sh` was previously configured, the `osu-web` `/multiplayer` routes and `osu-server-spectator` `/multiplayer` routes would conflict with each other, with the `osu-server-spectator` route taking precedence. This would mean that some `osu-web` pages would just straight up not be available on dev. To counteract this, the `osu-server-spectator` routes are now exposed under `https://dev.ppy.sh/signalr/`. This PR updates the client-side configuration to use these new routes.
peppy
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the way
dev.ppy.shwas previously configured, theosu-web/multiplayerroutes andosu-server-spectator/multiplayerroutes would conflict with each other, with theosu-server-spectatorroute taking precedence. This would mean that someosu-webpages would just straight up not be available on dev.To counteract this, the
osu-server-spectatorroutes are now exposed underhttps://dev.ppy.sh/signalr/. This PR updates the client-side configuration to use these new routes.