Block input to objects lying under already-hit hitcircles when classic note lock is active #24720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24626
In the issue thread, I stated that this would be "fixed" by #24280; as it turns out upon further investigation that was not the case, and the test cases I had only "worked" due to specific timings. However, as it also turns out, the API surface that permits hit circles to block input on objects underneath them already exists, and makes implementing this relatively painless. So I'm PRing this as a RFC to see if this is something that would be considered acceptable.
The behaviour proposed by this PR is as follows:
Test coverage for both behaviours above is included in 40d1196.
Videos for reference:
master
2023-09-05.23-00-13.mp4
this PR
2023-09-05.23-02-31.mp4
stable
2023-09-05.23-01-44.mp4