Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block input to objects lying under already-hit hitcircles when classic note lock is active #24720

Merged
merged 3 commits into from Sep 6, 2023

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 5, 2023

Closes #24626

In the issue thread, I stated that this would be "fixed" by #24280; as it turns out upon further investigation that was not the case, and the test cases I had only "worked" due to specific timings. However, as it also turns out, the API surface that permits hit circles to block input on objects underneath them already exists, and makes implementing this relatively painless. So I'm PRing this as a RFC to see if this is something that would be considered acceptable.

The behaviour proposed by this PR is as follows:

  • With classic mod disabled, already-judged circles allow input to reach other objects underneath them.
  • With classic mod enabled (specifically, with the "classic note lock" option enabled), already-judged circles block input from reaching objects underneath them.

Test coverage for both behaviours above is included in 40d1196.

Videos for reference:

master

2023-09-05.23-00-13.mp4

this PR

2023-09-05.23-02-31.mp4

stable

2023-09-05.23-01-44.mp4

@peppy peppy merged commit 4dafd4c into ppy:master Sep 6, 2023
15 of 17 checks passed
@bdach bdach deleted the overlapping-hit-circle-input branch September 6, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Possible difference between lazer and stable in input handling with overlapping sliders
2 participants