Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues after storyboard resource lookup refactor #24863

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix issues after storyboard resource lookup refactor #24863

merged 2 commits into from
Sep 20, 2023

Commits on Sep 19, 2023

  1. Fix StoryboardResourceLookupStore dying on failure to unmap path 

    Before the introduction of `StoryboardResourceLookupStore`, missing
files would softly fail by use of null fallbacks. After the
aforementioned class was added, however, the fallbacks would not work
anymore if for whatever reason `GetStoragePathFromStoryboardPath()`
failed to unmap the storyboard asset name to a storage path.
    @bdach
    bdach committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ba518e1 View commit details
    Browse the repository at this point in the history

  2. Fix DrawableStoryboardVideo attempting to unmap path once too much 

    The `StoryboardResourceLookupStore` cached at storyboard level is
supposed to already be handling that; no need for local logic anymore.
    @bdach
    bdach committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    641e651 View commit details
    Browse the repository at this point in the history