Fix argon health bar not completing flash animation correctly #25074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm... not sure this pull actually visually changes anything? I'm trying to see what it does, slowing down to like 10%, but I still cannot tell what this is supposed to be changing and in which scenario. How do I see the effects of this change? |
|
Before: osu.2023-10-10.at.07.24.56.mp4After: osu.2023-10-10.at.07.25.59.mp4The majority of the flash's intensity was being cancelled by |
bdach
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while doing some work around the health bar. The flash just wasn't playing due to an oversight in the miss-finish-animation logic.
I've also adjusted the flash a bit.