Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default preview point being incorrect on old beatmaps #25083

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix default preview point being incorrect on old beatmaps #25083

merged 2 commits into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. Add failing test coverage of incorrect default preview time

    @peppy
    peppy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7220ca3 View commit details
    Browse the repository at this point in the history

  2. Fix beatmaps with no preview point set getting incorrect default 

    Note that this will require a re-import to fix existing beatmaps
becuse.. it's stored to realm. Probably not worth worrying about for
now.
    @peppy
    peppy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2781846 View commit details
    Browse the repository at this point in the history