Change osu!mania "perfect" judgements to only award bonus score #25111
Conversation
There was a problem hiding this comment.
Quick skim, not putting too much into it since tests are still failing. Will also definitely want to rack @smoogipoo's brains on this one if possible.
|
while testing this pr, it seems like hold notes, when hit with anything but perfect will result in a greyed hold body Master: this pr: |
Good catch. I wasn't testing with legacy skins so completely missed this. Fixed in 14fedff. |
They're very dead now.
There was a problem hiding this comment.
This seems fine.
Not sure if @smoogipoo wants to do a once-over here but as far as I'm concerned this looks ready to go.
| return 315; | ||
| return 300; |
There was a problem hiding this comment.
I don't really feel good about this and what it means for the existence of numeric judgement results as a whole...
There was a problem hiding this comment.
I suppose we can try going down this path, though I'm concerned we're starting to lose the meaning of what a judgement's numeric result is and why it needs to be these specific numbers in the first place.
This also needs to be updated now: https://github.com/ppy/osu/wiki/Scoring
It is a concern I had. But for now I think the goal is to aim for player acceptance, and we can grind teeth and accept this from our end in order to see if we have things in a place osu!mania community is happy with. (and probably never change it, but oh well) |
Has been done. I think. |
RFC. Tests will be failing.
Closes #24238.