Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up mod usability flags #25328

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Clean up mod usability flags #25328

merged 6 commits into from
Nov 1, 2023

Commits on Oct 31, 2023

  1. Add xmldoc to Mod playability flags

    @bdach
    bdach committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7ea298a View commit details
    Browse the repository at this point in the history

  2. Seal ModAutoplay playability flags 

    Can't do much more than that due to the unfortunate fact of Cinema
inheriting from Autoplay.
    @bdach
    bdach committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3a2645e View commit details
    Browse the repository at this point in the history

  3. Seal ModScoreV2 

    Nobody should ever need to extend it.
    @bdach
    bdach committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    456f4eb View commit details
    Browse the repository at this point in the history

  4. Mark ModScoreV2 as invalid for multiplayer 

    Doesn't do much for the client; mostly a safety for osu-web's sake,
as without the change it could theoretically fail to validate the mod
properly in multiplayer contexts.
    @bdach
    bdach committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a644c75 View commit details
    Browse the repository at this point in the history

  5. Seal UnknownMod 

    Not a class for extension.
    @bdach
    bdach committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    955e2ed View commit details
    Browse the repository at this point in the history

  6. Seal a few more multiplayer playability flags of rate-changing mods 

    Not really changing anything, just tightening things down to curb
possible funny business.
    @bdach
    bdach committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a90f8dd View commit details
    Browse the repository at this point in the history