Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce elements hidden by letterboxing break overlays #2541

Merged
merged 5 commits into from May 14, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 14, 2018

  1. The hud would be underneath it.
  2. The ruleset cursor would be underneath it.

Tested on https://osu.ppy.sh/s/755651 (first break).

@smoogipoo smoogipoo added this to the May 2018 milestone May 14, 2018
@peppy
Copy link
Member

@peppy peppy commented May 14, 2018

Cursor is below interface

Pasted Image 1.png

@@ -149,6 +149,8 @@ private void load(AudioManager audio, APIAccess api, OsuConfigManager config)

scoreProcessor = RulesetContainer.CreateScoreProcessor();

Drawable rulesetCursor = RulesetContainer.Cursor?.CreateProxy() ?? new Container();

This comment has been minimized.

@peppy

peppy May 14, 2018
Member

can we move this to be inline?

@peppy
peppy approved these changes May 14, 2018
@peppy peppy merged commit 5d3449d into ppy:master May 14, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:hud-above-letterbox branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants