Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upReduce elements hidden by letterboxing break overlays #2541
Conversation
smoogipoo
added some commits
May 14, 2018
smoogipoo
added
the
gameplay
label
May 14, 2018
smoogipoo
added this to the May 2018 milestone
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Cursor is below interface |
osu.Game/Screens/Play/Player.cs
Outdated
| @@ -149,6 +149,8 @@ private void load(AudioManager audio, APIAccess api, OsuConfigManager config) | ||
| scoreProcessor = RulesetContainer.CreateScoreProcessor(); | ||
| Drawable rulesetCursor = RulesetContainer.Cursor?.CreateProxy() ?? new Container(); |
This comment has been minimized.
This comment has been minimized.
peppy
merged commit 5d3449d
into
ppy:master
May 14, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
smoogipoo
deleted the
smoogipoo:hud-above-letterbox
branch
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
smoogipoo commentedMay 14, 2018
Tested on https://osu.ppy.sh/s/755651 (first break).