Fix a couple of new r# inspections #25552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Nov 23, 2023
| @@ -119,12 +119,11 @@ public double GetMostCommonBeatLength() | |||
| IBeatmap IBeatmap.Clone() => Clone(); | |||
|
|
|||
| public Beatmap<T> Clone() => (Beatmap<T>)MemberwiseClone(); | |||
|
|
|||
| public override string ToString() => BeatmapInfo.ToString(); | |||
There was a problem hiding this comment.
This thing I find slightly disconcerting because there's this but there's also
osu/osu.Game/Beatmaps/Beatmap.cs
Lines 29 to 30 in 9a6857b
osu/osu.Game/Beatmaps/Beatmap.cs
Lines 43 to 44 in 9a6857b
What are these other nullchecks? How does r# even infer that this can never be null, on a file with disabled nullability annotations no less?
There was a problem hiding this comment.
I've enabled NRT and fixed those. It does seem to pass the test gauntlet at least.
bdach
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.