Fix overlapping chat links crashing the game #25627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Partial fix for #25614. Partial because it doesn't produce the ideal parsing results. Ideal would be: "osu://edit/00:12:345 (1,2) - Test?"
If you think reaching the ideal is not required, the issue could be marked as completed.
Fixes cases where the same string could be parsed into multiple overlapping links. This was caused by the faulty "Check for encapsulated links" logic.
This PR:
LinkFlowContainer
so it doesn't crash if overlapping links are provided (it'll ignore any overlapping links and log the problem)handleAdvanced()
, so I took the new logic from there