Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlapping chat links crashing the game #25627

Merged
merged 7 commits into from
Dec 2, 2023
Merged

Fix overlapping chat links crashing the game #25627

merged 7 commits into from
Dec 2, 2023

Commits on Nov 30, 2023

  1. Add passing tests

    @Susko3
    Susko3 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7f9ae55 View commit details
    Browse the repository at this point in the history

  2. Add failing tests 

    They throws `ArgumentOutOfRangeException` on the first drawable Update()
    @Susko3
    Susko3 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c395ae2 View commit details
    Browse the repository at this point in the history

  3. Ignore overlapping links instead of crashing

    @Susko3
    Susko3 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    152c7e5 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Extract Overlaps() logic to accept generic index and length

    @Susko3
    Susko3 committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    30bdd2d View commit details
    Browse the repository at this point in the history

  2. Use common Overlaps() logic 

    This actually fixes the problem and makes the tests pass
    @Susko3
    Susko3 committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d351799 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix-overlapping-chat-links

    @bdach
    bdach committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    30a4e77 View commit details
    Browse the repository at this point in the history

  4. Rename to more readable names

    @Susko3
    Susko3 committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    abb4c94 View commit details
    Browse the repository at this point in the history