Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converted beatmap hitwindows not working correctly #2567

Merged
merged 3 commits into from May 18, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 17, 2018

There were two issues:

  1. Hit windows were correct when the ruleset matched the beatmap's ruleset, i.e. mania beatmap with mania ruleset. But hit windows were not correct when the rulesets didn't match - mania would use osu!'s hit windows.
  2. Because hit windows were passed from the convert hitobjects, which are retained for the same working beatmap, mania could mangle the hit windows and add lenience / allow-oks / allow-perfects, and osu! would next time use those same mangled hit windows.
@smoogipoo smoogipoo added this to the May 2018 milestone May 17, 2018
@peppy
peppy approved these changes May 18, 2018
@peppy peppy merged commit 2582bf1 into ppy:master May 18, 2018
2 checks passed
2 checks passed
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:fix-conversion-hitwindows branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.