Fix GetRateAdjustedDisplayDifficulty() (partially incorrectly) locally reimplementing difficulty range calculations
#25762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal reimplementations Also adds explicit references to places from where the magic constants were lifted.
bdach
added
type:code-quality
area:ruleset-api
next release
Both smoogi and I were fine with this being local (and somewhat a mess) because it's used for display only and contains a whole heap of random calculations which take time to understand. I'd leave it up to the community to fix any issues because I don't have enough knowledge of what people expect with this stuff 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #25759 (comment), I'm not sure how this passed review.
The
GetRateAdjustedDisplayDifficulty()implementations now share the same sources of truths as the actual gameplay pieces that calculate AR / OD - whether it be constants that are then used to calculateTimePreemptfor AD, or the hitwindow ranges from{Osu,Taiko}HitWindows.Notably, this fixes a regression in the local catch reimplementation committed in a04f9aa (the condition changed from
adjustedDifficulty.ApproachRate < 5toadjustedDifficulty.ApproachRate < 6). This is covered by test cases added in 555559c.@Givikap120 for your consideration.