Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback column colors for legacy split stage mania skins #25787

Merged
merged 1 commit into from Dec 16, 2023

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Dec 16, 2023

the comment is copied from

// Account for cases like dual-stage (assume that all stages have the same column count for now).
columnIndex %= stage.Columns;

this can be tested in the Skinning > Playfield mania visual test. the expected behavior is that each stage will have the same column coloring

@peppy peppy merged commit b081440 into ppy:master Dec 16, 2023
13 of 17 checks passed
@cl8n cl8n deleted the fix-mania-column-color branch December 16, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants