Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argon pro not showing slider tick judgements #25972

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix argon pro not showing slider tick judgements #25972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6a331b
Fix argon pro not showing slider tick judgements
bdach Dec 20, 2023
fa4c905
Merge branch 'master' into argon-pro-no-slider-tick-judgements
peppy Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Osu/Skinning/Argon/OsuArgonSkinTransformer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public OsuArgonSkinTransformer(ISkin skin)
{
case GameplaySkinComponentLookup<HitResult> resultComponent:
// This should eventually be moved to a skin setting, when supported.
if (Skin is ArgonProSkin && resultComponent.Component >= HitResult.Great)
if (Skin is ArgonProSkin && (resultComponent.Component == HitResult.Great || resultComponent.Component == HitResult.Perfect))
return Drawable.Empty();

return new ArgonJudgementPiece(resultComponent.Component);
Expand Down