Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beats being counted incorrectly in the timing editor #26281

Merged
merged 2 commits into from Jan 2, 2024

Conversation

iminlikewithyou
Copy link
Contributor

Fixes #26263

this PR fixes a bug where the incorrect beat index was showing due to a rounding error

these poor timing variables are getting multiplied and divided and remultiplied and redivided again

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be okay.

@peppy peppy merged commit 5b8e9a5 into ppy:master Jan 2, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The waveform comparison display doesn't always count beat snaps correctly
2 participants