Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date failing to display on leaderboard for some scores with weird datetimes #26526

Merged
merged 1 commit into from Jan 14, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jan 14, 2024

Addresses #26517.

The score reported has a datetime of 0001/1/1 05:00:00 AM.

Bit of a dodge fix but maybe fine?

… datetimes

Addresses ppy#26517.

The score reported has a datetime of 0001/1/1 05:00:00 AM.

Bit of a dodge fix but maybe fine?
Copy link
Member

@frenzibyte frenzibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Also had a look at the score itself and made sure there are no other places where it could crash, hopefully I haven't missed a place.

@peppy peppy merged commit a8b301c into ppy:master Jan 14, 2024
11 of 17 checks passed
@bdach bdach deleted the fix-date-display-failing branch January 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants