Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement difficulty tooltips for multiplayer lobbies #26531

Merged
merged 23 commits into from
Feb 22, 2024

Swap AR and OD on tooltips

7861125
Select commit
Failed to load commit list.
Sign in for the full log view
Merged

Implement difficulty tooltips for multiplayer lobbies #26531

Swap AR and OD on tooltips
7861125
Select commit
Failed to load commit list.
GitHub Actions / Test Results (Windows, SingleThread) failed Feb 22, 2024 in 0s

Test Results (Windows, SingleThread) ❌

Tests failed

❌ TestResults-Windows-SingleThread.trx

5618 tests were completed in 1692s with 5565 passed, 1 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn 16✔️ 1❌ 3s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn

✔️ TestConstructor
✔️ TestLeadInProducesCorrectStartTime(1000,0)
✔️ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✔️ TestLeadInProducesCorrectStartTime(2000,0)
✔️ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
❌ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
	TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -1000.0d +/- 100.0d
	  But was:  -817.57370000000003d
	  Off by:   -182.42629999999997d
	
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)

Annotations

Check failure on line 0 in TestResults-Windows-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -1000.0d +/- 100.0d
    But was:  -817.57370000000003d
    Off by:   -182.42629999999997d
  
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -1000.0d +/- 100.0d
  But was:  -817.57370000000003d
  Off by:   -182.42629999999997d

--TearDown
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)