Implement difficulty tooltips for multiplayer lobbies #26531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Jan 17, 2024
- Change difficultyicon mods parameter docstring to be more professional - Add a parameter for controlling whether the difficulty statistics show or not. Defaults to false - Round the BPM in the tooltip to make sure it displays correctly
bdach
reviewed
Jan 17, 2024
peppy
reviewed
Jan 18, 2024
peppy
requested changes
Jan 22, 2024
peppy
previously approved these changes
Jan 25, 2024
|
There's quite a bit of duplicated code here but we can deal with it later. |
bdach
changed the title
Matches everything else.
bdach
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the discussion happened in #11306, and the issue can be closed if this is merged. This PR effectively adds difficulty information to the tooltip of maps in multiplayer lobbies.
Here is a preview of what it looks like:
The difficulty statistics update based on the mods applied, with the exception of the star rating (see below). I've done testing and found that it works regardless of whether the map is downloaded or not. Peppy said that this should be fine for the time being, until a new design is implemented. Which I can agree with.
Known issues
difficultyCache.getDifficultyAsync()but to no avail. In the end I wasn't able to find a way to get the star rating to update, so I'll be leaving it for another contributor to implement. I suggest a new issue is opened for this if the PR gets merged.