De-dupe displayed hits in judgement counter #26540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
approved these changes
Jan 15, 2024
Comment on lines
+92
to
+94
| var hitResult = counter.Result.Types.First(); | ||
|
|
||
| if (hitResult.IsBasic()) |
There was a problem hiding this comment.
this sort of stuff is pretty dodgy, but i guess it's also isolated display logic, so i can sort of pretend to not see this for now...
There was a problem hiding this comment.
Haven't changed from what was there 🤷
There was a problem hiding this comment.
To expound on the above, the .First() is what I take issue with specifically. There is nothing guaranteeing that the "chosen" result from the potential multiple in the given "result type grouping" represents the rest in terms of these .IsBasic() / .IsBonus() checks.
There was a problem hiding this comment.
ah, right. yeah, that is what it is, i have no better ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26514.
Not sure how useful showing slider end hits is when misses isn't shown... but hey.
This also reduces LINQ overhead that was present previously.