Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy animated judgements not fading out correctly #26839

Merged
merged 1 commit into from
Jan 31, 2024

Revert "Move fade more local to avoid fading twice"

c5e118b
Select commit
Failed to load commit list.
Sign in for the full log view
Merged

Fix legacy animated judgements not fading out correctly #26839

Revert "Move fade more local to avoid fading twice"
c5e118b
Select commit
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded) failed Jan 30, 2024 in 0s

Test Results (macOS, MultiThreaded) ❌

Tests failed

❌ TestResults-macOS-MultiThreaded.trx

5559 tests were completed in 1817s with 5504 passed, 3 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope 3✔️ 1❌ 14s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSingleTap 4✔️ 1❌ 15s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSpunOut 5✔️ 1❌ 16s

❌ osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope

✔️ TestAlwaysHidden
✔️ TestConstructor
✔️ TestVisibleAfterComboBreak
❌ TestVisibleDuringBreak
	TearDown : System.TimeoutException : "wait for end of break" timed out

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSingleTap

✔️ TestConstructor
✔️ TestInputAlternating
✔️ TestInputAlternatingAtIntro
✔️ TestInputAlternatingWithBreak
❌ TestInputSingular
	TearDown : System.TimeoutException : "test passed" timed out

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSpunOut

✔️ TestConstructor
✔️ TestSpinnerAutoCompleted
✔️ TestSpinnerGetsNoBonusScore
✔️ TestSpinRateUnaffectedByMods(null)
✔️ TestSpinRateUnaffectedByMods(osu.Game.Rulesets.Osu.Mods.OsuModDoubleTime)
❌ TestSpinRateUnaffectedByMods(osu.Game.Rulesets.Osu.Mods.OsuModHalfTime)
	TearDown : System.TimeoutException : "test passed" timed out

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope ► TestVisibleDuringBreak 

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "wait for end of break" timed out
Raw output 
TearDown : System.TimeoutException : "wait for end of break" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSingleTap ► TestInputSingular 

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "test passed" timed out
Raw output 
TearDown : System.TimeoutException : "test passed" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSpunOut ► TestSpinRateUnaffectedByMods(osu.Game.Rulesets.Osu.Mods.OsuModHalfTime) 

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "test passed" timed out
Raw output 
TearDown : System.TimeoutException : "test passed" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
View more details on GitHub Actions