New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve silence detection in MutedNotification
#26951
Merged
Merged
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dfd966e
Improve silence detection in `MutedNotification`
myQwil 3122211
Change silence threshold and target restore volume level
myQwil f4a2d5f
Round off inaccuracies in the aggregate volume before evaluating
myQwil 5d9200b
Update tests to reflect new restore target volume
myQwil c60e110
Try to fix code quality issues raised by workflow
myQwil 29a2890
fix code quality error #2
myQwil 906560f
Fix mute button test
myQwil e4ec8c1
give better volume names to `addVolumeSteps`
myQwil 2ab967f
Increase precision of aggregate volume rounding
myQwil 9a53485
Replace aggregate rounding method with a float cast
myQwil a9eac59
Remove seemingly unnecessary float casts
frenzibyte d81b148
Remove mention of decibel units in comment
frenzibyte 5431781
Bring back target volume to 50%
frenzibyte 6751f95
Adjust test cases and approximate equality
frenzibyte 7530b1f
Adjust comment again
frenzibyte df40f55
Merge branch 'master' into mute_detection
frenzibyte 22dafd8
fix typo
myQwil 9f53185
Revert changes to muted notification action
frenzibyte 6a1d118
Adjust tests again
frenzibyte 952c5b0
Use `Precision.AlmostBigger`
frenzibyte 583e716
Always bring master/music volume to 50%
frenzibyte bbd7706
Merge branch 'master' into mute_detection
frenzibyte File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all so black box to a user. I'd still prefer the old hard cut increases, then let the user adjust further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine, I agree it's a touch more complicated/arbitrary but wasn't sure if it warrants a discussion.