Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected room bindable being set to null regardless of the removed room #27033

Merged
merged 4 commits into from Feb 5, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Feb 4, 2024

Briefly discussed in discord. The bindable was supposed to be updated only when the selected room matches a removed room (therefore clearing selection), but was refactored at some point and the conditions appeared to be incorrectly removed (see 8222255#diff-6641e1f909bc58c5179c3c0b386be672449b434087378a72ee99557118db305aL103-R102). I cannot seem to find any positive/negative behavioural change caused by this.

@bdach
Copy link
Collaborator

bdach commented Feb 5, 2024

but was refactored at some point and the conditions appeared to be incorrectly removed (see 4d6101f)

I think you linked the wrong rev? I'd think 8222255 is where the issue started, no?

Edit: yeah the above rev is what you linked here even. Bit confusing but sure.

@bdach bdach enabled auto-merge February 5, 2024 18:58
@frenzibyte
Copy link
Member Author

Yeah my bad.

@bdach bdach disabled auto-merge February 5, 2024 20:04
@bdach bdach merged commit 938bbe3 into ppy:master Feb 5, 2024
15 of 17 checks passed
@frenzibyte frenzibyte deleted the fix-rooms-container-something branch February 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants