Fix DrawableLinkCompiler allocations
#27199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My dotMemory tools are busted, refraining from review. |
peppy
reviewed
Feb 17, 2024
| @@ -23,12 +25,21 @@ public partial class DrawableLinkCompiler : OsuHoverContainer | |||
| /// <summary> | |||
| /// Each word part of a chat link (split for word-wrap support). | |||
| /// </summary> | |||
| public readonly List<Drawable> Parts; | |||
| public readonly SlimReadOnlyListWrapper<Drawable> Parts; | |||
There was a problem hiding this comment.
The change of type here was just to limit outwards mutability, yeah?
There was a problem hiding this comment.
Yep. It's not used anywhere aside from tests either way, so felt safe.
peppy
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar fix to #26790
Values have been taken while idling in
BeatmapOverlayand looking at the leaderboard (it has many user links).