Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce mania editor allocations with many objects selected #27275

Merged
merged 4 commits into from Feb 21, 2024

Conversation

EVAST9919
Copy link
Contributor

@EVAST9919 EVAST9919 commented Feb 20, 2024

master pr
master pr

Last big one is caused by .Reverse() in

foreach (var b in SelectionBlueprints.Reverse())
since it allocates a new array under the hood. Needs rethinking probably.

@peppy peppy merged commit 949ea29 into ppy:master Feb 21, 2024
11 of 17 checks passed
@peppy peppy self-requested a review February 21, 2024 07:06
@EVAST9919 EVAST9919 deleted the mania-editor-alloc branch February 21, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants