Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classic skin follow circles animating from incorrect starting point #27288

Merged
merged 1 commit into from Feb 21, 2024

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Feb 21, 2024

I don't know how this happened, but it looks completely wrong. The follower was starting from inside the circle.

Reference

@frenzibyte
Copy link
Member

Is the reference link correct? I'm not sure what it signifies.

@peppy
Copy link
Sponsor Member Author

peppy commented Feb 21, 2024

Is the reference link correct? I'm not sure what it signifies.

2024-02-21 17 06 14@2x

notice: 1 -> 2, not 0.5 -> 2.

@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Feb 21, 2024
@bdach bdach self-requested a review February 21, 2024 09:09
@bdach
Copy link
Collaborator

bdach commented Feb 21, 2024

The 0.5 blames back to 7ed4eb5. I assume what that was trying to replicate was this, but it isn't entirely clear to me why it was doing 0.5 -> 2 and not either 0.5 -> 1 or 1 -> 2.......

@bdach
Copy link
Collaborator

bdach commented Feb 21, 2024

Okay the fact that the scale specs are doubled is explained by

// follow circles are 2x the hitcircle resolution in legacy skins (since they are scaled down from >1x
animationContent.Scale *= 0.5f;

Did a visual comparison against stable, it's difficult to tell at such high speeds whether it's matching because of frame pacing alone, but it seems closer to what it should be.

@bdach bdach merged commit cd1acf1 into ppy:master Feb 21, 2024
13 of 17 checks passed
@peppy peppy deleted the fix-follow-circle-animation branch February 24, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gameplay next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! ruleset/osu! size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants