Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old-style legacy spinner fade-in not matching stable #27320

Merged
merged 2 commits into from Feb 23, 2024

Conversation

frenzibyte
Copy link
Member

This was supposed to have been adjusted in #20817 alongside LegacyNewStyleSpinner, but has been forgotten about.

Compare (LegacyNewStyleSpinner):

using (BeginAbsoluteSequence(spinner.StartTime - spinner.TimeFadeIn))
this.FadeInFromZero(spinner.TimeFadeIn);

Also see stable reference and notice transformation there is same regardless of spinner style.

@peppy peppy self-requested a review February 23, 2024 04:20
@peppy peppy merged commit d544b4d into ppy:master Feb 23, 2024
15 of 17 checks passed
@frenzibyte frenzibyte deleted the adjust-old-style-spinner branch February 23, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinners appear faster when using some skins
2 participants