Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user statistics updates on multiplayer and playlists results screens #27331

Merged
merged 5 commits into from Feb 29, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Feb 22, 2024

I'm not sure if this has a tracking issue but was pointed out here for sure.

Also includes some renames to SoloStatisticsWatcher & co. to shed the "solo" naming, as well as a slight refactor of ResultsScreen to prefer init bool properties to bool ctor params.

Copy link
Member

@frenzibyte frenzibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll note that it's hard for me to test this as the development server does not support updating user statistics from score submissions yet, but overall it looks good and sounds like it should work.

@peppy peppy self-requested a review February 29, 2024 04:05
@peppy peppy merged commit f44aada into ppy:master Feb 29, 2024
15 of 17 checks passed
@bdach bdach deleted the statistics-updates-in-multi branch February 29, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants