Add "Argon" performance points counter

[frenzibyte]

This was supposed to be implemented very long ago but things happened and it fell off my radar. Anyway, here it is.

Preview:

CleanShot.2024-03-05.at.03.56.14.mp4

The counter's design is mostly based off figma, unlike the small number design in #25362. Placement choice is completely arbitrary and likely not going live without expert touches (especially the label flying off to the left as the digits of the PP counter increases).

[frenzibyte]

I don't quite understand this test failure (it's in deserialisation skin test), I'll look at it later/tomorrow unless someone beats me to it.

[peppy]

Should probably have 3 digits placeholder to avoid the shifting label in 98% of cases.

Also I'd probably size it a bit smaller. compared to accuracy if we're putting it there.

@arflyte any input?

[frenzibyte]

I thought about adding that at first for the same reason, I can't remember why I was against it though. I'll add it and see how it feels.

[arflyte]

The label must not shift in any circumstances. I'd suggest keeping it to 3 digits and show 999 if it goes beyond it. Put Accuracy and PP in the same line instead of stacked; this will fix left aligned contents when placed on the right side of the screen.

(I just noticed the vibrating combo label, but that's fine; it gives a bit of flavour there.)

[peppy]

show 999 if it goes beyond it

what. i don't think you understand pp? it WILL go above 1,000 in high level play.

[Givikap120]

show 999 if it goes beyond it

what. i don't think you understand pp? it WILL go above 1,000 in high level play.

Well, 4 digit placeholder is good, cuz it won't be higher than 4 digit in a human play
But even tho it will only occurs in auto scores - i don't think clamping it at 9999 is a good idea

[peppy]

I guess I have to @arflyte highlight every time to actually get a response? @arflyte

[arflyte]

Yeah lol, I can't keep up with the PP thing now. I thought reaching 4 digits was inhuman or something lol.

Then put both Accuracy and PP in line with 4 digits. It'd be best if it comes with toggle, because it feels weird to have 4th digit mostly unused; but probably that'd give motivation for beginners to hit 4 digits i guess.

[peppy]

I'm going to disagree on this one then. Please use 3 digits of placeholder for now and allow the label to move on hitting four.

[peppy]

I don't quite understand this test failure (it's in deserialisation skin test), I'll look at it later/tomorrow unless someone beats me to it.

3 days later so I'm taking over this PR.

The test failure is because you renamed a previous non-abstract type to now be a base type. This is a breaking change and what that test is intended to catch. It means that skins which used this type will actually be broken by this PR.

I'll look at fixing.

[arflyte]

Hmm, it's probably wouldn't be that jarring if the label moves if both stats are inline. I guess it's time to explore grouping options for the skin editor.