Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thankfully these don't seem to be affecting much right now because gameplay/editor is relatively isolated via
RulesetSkinProvidingContainer
.But, from within the context of either, this could cause problems. For example, delete all hitobjects -> trigger skin change -> delegate still invoked on now-disposed
TimelineHitObjectBlueprint
s.The same could happen for gameplay with, for example, mod toggling.