Fix 1px flashlight gaps when gameplay scaling mode is active #27533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#27522. Concerns mostly taiko and catch. Not much of a proper fix rather than a workaround but it is what it is. I tried a few other things, including setting `MaskingSmoothness = 0` on the scaling container itself, to no avail.
bdach
added
ruleset/osu!taiko
ruleset/osu!catch
area:mods
next release
peppy
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27522.
Concerns mostly taiko and catch.
Not much of a proper fix rather than a workaround but it is what it is. I tried a few other things, including setting
MaskingSmoothness = 0on the scaling container itself, to no avail.Scaling settings used @ 1920x1080:
Footnotes
Just for visual reference that nothing has visually regressed. ↩ ↩2
There are actual 1px gaps visible here. ↩ ↩2