Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruleset medals not displaying due to deserialisation failure #27574

Merged
merged 1 commit into from Mar 11, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Mar 11, 2024

馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う

probably got confused and lifted ushort from the database instead of the actual structure (https://github.com/ppy/osu-web/blob/b29eeff28e100bd5ed43a26f355575f19918e556/app/Models/Achievement.php#L14).

reported in https://discord.com/channels/188630481301012481/188630652340404224/1216812697589518386.

can be tested full-stack using same procedure as described in #27276, just do a UPDATE osu_achievements SET mode = 1 WHERE achievement_id = 18; or similar on your chosen achievement before.

馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う馃う

Reported in
https://discord.com/channels/188630481301012481/188630652340404224/1216812697589518386.
@bdach bdach added type:online next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Mar 11, 2024
@bdach bdach requested a review from a team March 11, 2024 20:36
@peppy peppy merged commit 301750f into ppy:master Mar 11, 2024
15 of 17 checks passed
@bdach bdach deleted the fix-invalid-type branch March 12, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/XS type:online
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants